Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use idna package for normalize host #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moeb1376
Copy link

Add idna package to dependencies.
Remove python 2.7 from supported python versions.

Add idna package to dependencies.
Remove python 2.7 from supported python versions.
@moeb1376 moeb1376 changed the title Use idna for normalize host Use idna package for normalize host Jul 27, 2022
@@ -14,8 +14,9 @@ version = "1.4.3"
"Changelog" = "https://github.com/niksite/url-normalize#url-normalize"

[tool.poetry.dependencies]
python = "~2.7 || ^3.6"
python = "^3.6"
six = "*"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If python 2.7 support is dropped, six (and its usage in tools.py) could also be removed.

@JWCook
Copy link

JWCook commented Sep 20, 2023

I like this idea, since any project dealing with URLs almost certainly already has idna as a transitive dependency (via an HTTP client or server library like requests or aiohttp).

@a-detiste
Copy link

a-detiste commented Jan 12, 2024

We are removind old Python2+3 compat from Debian: future, six, unittest2, mock...

I was considering patching this one downstream because I have it on my own PC... but having this change upstream is much better :-)

Greetings

https://wiki.debian.org/Python3-six-removal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants