Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: URL handling and validation logic #42

Merged
merged 1 commit into from
Apr 13, 2024
Merged

refactor: URL handling and validation logic #42

merged 1 commit into from
Apr 13, 2024

Conversation

nicopico-dev
Copy link
Owner

missing commit from #39

@nicopico-dev
refactor: URL handling and validation logic
efa40f7 
url without protocol should be assumed valid for newsletter request
@github-actions GitHub Actions
Copy link

Code Coverage

File Coverage [93.72%]
src/main/kotlin/fr/nicopico/n2rss/controller/home/HomeController.kt 91.67%
src/main/kotlin/fr/nicopico/n2rss/mail/newsletter/AndroidWeeklyNewsletterHandler.kt 93.75%
src/main/kotlin/fr/nicopico/n2rss/mail/newsletter/KotlinWeeklyNewsletterHandler.kt 91.89%
src/main/kotlin/fr/nicopico/n2rss/mail/newsletter/PointerNewsletterHandler.kt 94.74%
src/main/kotlin/fr/nicopico/n2rss/utils/url/UrlExt.kt 100.00%
src/main/kotlin/fr/nicopico/n2rss/utils/url/UrlValidator.kt 100.00%
Total Project Coverage 89.89%

@nicopico-dev nicopico-dev merged commit 2b32c0d into main Apr 13, 2024
2 checks passed
@nicopico-dev nicopico-dev deleted the feat/request-a-newsletter branch April 13, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nicopico-dev