Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect variable type #3

Open
dmatthe4952 opened this issue Feb 17, 2022 · 2 comments
Open

Incorrect variable type #3

dmatthe4952 opened this issue Feb 17, 2022 · 2 comments

Comments

@dmatthe4952
Copy link

In the lecture 94, you have elf32_off defined as a int32_t. The manual I am looking at describes it as an unsigned 4 byte integer. Wouldn't that be uint32_t?

@nibblebits
Copy link
Owner

Thanks very much for this, it will be useful for other students who come to this repository.
Message for the students: This should not be a huge problem for our simple kernel because even with a signed integer we still have over 2 billion bytes to work with. However yes the ELF manual does state that it should be unsigned, feel free to change it if you feel the need too.
I will be making a new video soon to fix some of the found issues in this repository.

Thanks again for spotting that.

@nibblebits
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants