Bug in fat16_get_first_cluster

[gierens]

Correct me if I'm wrong but we are just ORing the high and low bits here:

PeachOS/src/fs/fat/fat16.c

Lines 355 to 358 in 9518f7a

	static uint32_t fat16_get_first_cluster(struct fat_directory_item *item)
	{
	return (item->high_16_bits_first_cluster) | item->low_16_bits_first_cluster;
	};

Shouldn't we shift the high bits like so:

return (item->high_16_bits_first_cluster << 16) | item->low_16_bits_first_cluster;

[nibblebits]

Yes you are correct, this function by the end of the course does not get used anymore, it will be removed in a future lecture entirely

[nibblebits]

Thanks for mentioning the issue