Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ConfigureLCRCompensation and GetLCRCompensationData in nidcpower GrpcStubInterpreter #1920

Open
ni-jfitzger opened this issue Apr 11, 2023 · 1 comment

Comments

@ni-jfitzger
Copy link
Collaborator

Description of issue

For the nimi-python 1.4.4 release, the nidcpower.proto was missing 2 Functions.

This is because of 2 things:

  • The metadata for the grpc and nimi-python had the function/method turned off until very close to release (though they were part of a previous NI-DCPower release)
    • This meant ni_grpc_device_server.exe on the nimibot runners wouldn't recognize the functions, even if they made it into nidcpower.proto.
  • The process for updating the metadata in the grpc-device repo is manual and it happens infrequently.

Once a new ni_grpc_device_server.exe is available on nimibot, we should add these methods by:

  • Updating nidcpower.proto
  • Removing the overrides in src/nidcpower/metadata/functions_addon.py that disable generation of the methods in GrpcStubInterpreter
@ni-jfitzger
Copy link
Collaborator Author

When fixing this, we should also update test_lcr_compensation_data to run for both the Library and the GrpcStubInterpreter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant