show useful error message in toast (#86)

* show useful error message in toast * udpate runs-on commit sha from github sha Co-authored-by: Devin Rasmussen <[email protected]>
nhumrich · Feb 11, 2022 · 808e658 · 808e658
1 parent 7056336
commit 808e658
Show file tree

Hide file tree

Showing 3 changed files with 7,728 additions and 5 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -1,12 +1,12 @@
-name: 
+name:
 
 on: [push]
 
 jobs:
   build:
 
     runs-on: ubuntu-latest
-    
+
     steps:
     - uses: actions/checkout@master
     - name: build docker
@@ -21,7 +21,7 @@ jobs:
 
   test:
     needs: build
-    runs-on: canopytax/toggle-meister:$GITHUB_SHA
+    runs-on: canopytax/toggle-meister:$CI_COMMIT_SHA
 
     steps:
     - name: test

diff --git a/tmeister/static/src/toggles/create/create-hooks.js b/tmeister/static/src/toggles/create/create-hooks.js
@@ -46,10 +46,14 @@ function useCreate({name, api, visibleError}) {
           setSaving(false)
           setSaved(true)
         } else {
-          throw new Error(`Server responded with status ${response.status}`);
+          throw response
         }
       }).catch(err => {
-        toasts.generalToast(`${visibleError}: ${JSON.stringify(err)}`)
+        if (err.text) {
+          err.json().then(text => toasts.generalToast(`${visibleError}: ${text.Message ? text.Message : text}`))
+        } else {
+          toasts.generalToast(`${visibleError}: ${err.status ? err.status : ''} ${err.message}`)
+        }
         setSaving(false)
         setSaved(false)
         throw new Error(err);