add app protocol to http builder #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I didn't add an Express example because Express 5 and http2 support is still in beta. 😂 |
OfTheDelmer
force-pushed
the
del/app-protocol
branch
from
cf16d6e
to
b64cdd6
Compare
KristopherPaulsen
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #107
Why
To allow specifying
http1orhttp2for listenersHow
Add
app_protocolto bothHTTPListenerBuilderandconfig.Add an example with node's http2 example.
Validation
Run example with local build and can view
Hello Worldin browser on listener url.