Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement readset return type types for modules #119

Open
mkuhn opened this issue Aug 20, 2019 · 2 comments
Open

Implement readset return type types for modules #119

mkuhn opened this issue Aug 20, 2019 · 2 comments

Comments

@mkuhn
Copy link
Collaborator

mkuhn commented Aug 20, 2019

We were trying to add a filtering step as an external module (having a read set as input and output). However, only counts and mapped read sets are supported at the moment, everything else throws an exception:

ret -> throwShouldNotOccur ("Not implemented (ExternalModules.hs:executeCommand commandReturnType = "++show ret++")")

We circumvented this by loading the results with load_mocat_sample, so we don't have an urgent need to have this added to the source code. But perhaps a note in the documentation on the rtype would be helpful.

@unode
Copy link
Member

unode commented Aug 20, 2019

Indeed the docs mention readset as a valid return type but the code linked above disagrees.

From an implementation point of view this will also require specifying how many fastq files are expected fq1 (single-end), fq2 (paired-end) or fq3(paired + single) since NGLess has to generate up to 3 output paths.

Another point to consider is if the external tool outputs only 1 file but in interleaved format, something we can now also handle.

@unode
Copy link
Member

unode commented Oct 18, 2019

I've updated documentation for now but leaving this issue open as we will want to implement support for readset in the future.

@luispedro luispedro changed the title Update documentation: supported return types for modules Implement readset return type types for modules May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants