You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We were trying to add a filtering step as an external module (having a read set as input and output). However, only counts and mapped read sets are supported at the moment, everything else throws an exception:
ret -> throwShouldNotOccur ("Not implemented (ExternalModules.hs:executeCommand commandReturnType = "++show ret++")")
We circumvented this by loading the results with load_mocat_sample, so we don't have an urgent need to have this added to the source code. But perhaps a note in the documentation on the rtype would be helpful.
The text was updated successfully, but these errors were encountered:
Indeed the docs mention readset as a valid return type but the code linked above disagrees.
From an implementation point of view this will also require specifying how many fastq files are expected fq1 (single-end), fq2 (paired-end) or fq3(paired + single) since NGLess has to generate up to 3 output paths.
Another point to consider is if the external tool outputs only 1 file but in interleaved format, something we can now also handle.
We were trying to add a filtering step as an external module (having a read set as input and output). However, only counts and mapped read sets are supported at the moment, everything else throws an exception:
ngless/NGLess/ExternalModules.hs
Line 284 in bd2bed1
We circumvented this by loading the results with
load_mocat_sample
, so we don't have an urgent need to have this added to the source code. But perhaps a note in the documentation on thertype
would be helpful.The text was updated successfully, but these errors were encountered: