ci(fix): Properly auto-update Dockerfiles using a build arg #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot will not generate PRs for Dockerfiles that include a build argument within their FROM instruction
4141done
reviewed
Aug 29, 2024
Dockerfile.plus
Outdated
| @@ -1,8 +1,8 @@ | |||
| ARG RELEASE=bookworm | |||
| FROM debian:${RELEASE}-slim@sha256:f528891ab1aa484bf7233dbcc84f3c806c3e427571d75510a9d74bb5ec535b33 | |||
| # ARG RELEASE=bookworm # Removing for the time being since it doesn't play well with Dependabot | |||
There was a problem hiding this comment.
If we are removing it let's just delete it for now
4141done
approved these changes
Aug 29, 2024
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Dependabot will not generate PRs for Dockerfiles that include a build argument within their FROM instruction. This PR fixes that issue.
Checklist
Before creating a pull request (PR), run through this checklist and mark each as complete:
README.md).