Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #206 -ec2 check to support IMDSv1 and IMDSv2 + moving env vars to conf file #212

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

orensharoni
Copy link
Contributor

we added support of IMDSv2 to the EC2 check with a fall back to IMDSv1,
also, some nginx env declarations were moved from the environment file to the nginx.conf file

@4141done
Copy link
Collaborator

Thank you for your contribution, @orensharoni - have been able to verify that this fixes your issue from #206 ?

I'll stand up an ec2 env and give it a check too.

@orensharoni
Copy link
Contributor Author

yes, I used it on my dev setup and the ec2 test and deployment work,
the access_key and access_token should be also verified if posible

@4141done
Copy link
Collaborator

yes, I used it on my dev setup and the ec2 test and deployment work, the access_key and access_token should be also verified if posible

Excellent, thank you for confirming. I'll do a quick check on my end and then merge

Copy link
Collaborator

@4141done 4141done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution. I tested these changes with the token approach and was able to verify it works well.

If you can correct the two typoes I highlighted we can go ahead and merge.

standalone_ubuntu_oss_install.sh Outdated Show resolved Hide resolved
standalone_ubuntu_oss_install.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@4141done 4141done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for your contribution! Also special thanks to @HighOnMikey
for noticing the wrong file path in the env var inclusion portion

@4141done 4141done merged commit 626d29d into nginxinc:master Feb 16, 2024
7 checks passed
@orensharoni orensharoni deleted the issue-#206-is-EC2-check branch February 18, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants