Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-wc: Update to wasmtime v26.0.1 #1485

Merged
merged 1 commit into from
Nov 7, 2024
Merged

wasm-wc: Update to wasmtime v26.0.1 #1485

merged 1 commit into from
Nov 7, 2024

Conversation

ac000
Copy link
Member

@ac000 ac000 commented Nov 6, 2024

This fixes an issue we had with wasm-wasi-component failing to load components with

  2024/11/06 21:08:50 [alert] 107196#107196 failed to create initial state

  Caused by:
      0: failed to compile component
      1: WebAssembly translation error
      2: Invalid input WebAssembly code at offset 15936: zero byte expected

Which was a symptom of
<https://github.com/bytecodealliance/wasmtime/issues/9130>

Closes: https://github.com/nginx/unit/issues/1477

Copy link
Contributor

@javorszky javorszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change, makes sense, thank you for the link to the issue, test passes, let's merge it! :shipit:

This fixes an issue we had with wasm-wasi-component failing to load
components with

  2024/11/06 21:08:50 [alert] 107196#107196 failed to create initial state

  Caused by:
      0: failed to compile component
      1: WebAssembly translation error
      2: Invalid input WebAssembly code at offset 15936: zero byte expected

Which was a symptom of
<bytecodealliance/wasmtime#9130>

Closes: nginx#1477
Signed-off-by: Andrew Clayton <[email protected]>
@ac000
Copy link
Member Author

ac000 commented Nov 7, 2024

Rebased with master

$ git range-diff 3df87657...e6519b9d
-:  -------- > 1:  158322ec auto: Remove unused pthread spinlock checks
1:  3df87657 = 2:  e6519b9d wasm-wc: Update to wasmtime v26.0.1

@ac000 ac000 merged commit e6519b9 into nginx:master Nov 7, 2024
24 checks passed
@ac000 ac000 deleted the wasm-wc branch November 7, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants