Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some more variable constification #1466

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Some more variable constification #1466

merged 1 commit into from
Oct 24, 2024

Conversation

ac000
Copy link
Member

@ac000 ac000 commented Oct 22, 2024

Mostly more 'static nxt_str_t ...'s

@ac000 ac000 marked this pull request as ready for review October 22, 2024 23:19
@ac000 ac000 requested a review from hongzhidao October 22, 2024 23:20
hongzhidao
hongzhidao approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@hongzhidao hongzhidao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ac000
Some more variable constification
ebd02c6 
Mostly more 'static nxt_str_t ...'s

Signed-off-by: Andrew Clayton <[email protected]>
@ac000
Copy link
Member Author

ac000 commented Oct 24, 2024

Rebased with master

$ git range-diff 485e637d...ebd02c60
-:  -------- > 1:  de430eda Add flag for newline control in access log entries
-:  -------- > 2:  76cc071a Fix missing newlines in access logs for JS configuration
1:  485e637d = 3:  ebd02c60 Some more variable constification

@ac000 ac000 merged commit ebd02c6 into nginx:master Oct 24, 2024
22 of 23 checks passed
@ac000 ac000 deleted the const branch October 24, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongzhidao hongzhidao hongzhidao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ac000 @hongzhidao