http: Fix router process crash whilst using proxy #1418
Merged
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac000
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Hi @hongzhidao
Good fix!
http: Fix router process crash whilst using proxy
When the client closes the connection before the upstream,
the proxy's error handler was calling cleanup operation like
peer close and requestclose twice, this fix ensures the cleanup
is performed only once, improving proxy stability.
Maybe requestclose should be request close?
hongzhidao
force-pushed
the
fix-proxy
branch
from
c0add76
to
ae90477
Compare
Fixed, thanks. |
hongzhidao
force-pushed
the
fix-proxy
branch
from
ae90477
to
5fde2ff
Compare
When the client closes the connection before the upstream, the proxy's error handler was calling cleanup operation like peer close and request close twice, this fix ensures the cleanup is performed only once, improving proxy stability. Closes: nginx#828
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the client closes the connection before the upstream, the proxy's error handler was calling cleanup operation like peer close and requestclose twice, this fix ensures the cleanup is performed only once, improving proxy stability.
Closes: #828