Update wasmtime to v18 #1143
Closed
Update wasmtime to v18 #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think waiting on the Actions CI PR to see if it still builds is a good idea. |
|
You also need to fix the checksum in SHA512SUMS. We use the contrib version to build our packages for all supported distros and docker images, so makes sense to also test if the builds don't fail (we don't have a BB integration for that). |
arbourd
force-pushed
the
update-wasmtime
branch
from
4872ffe
to
efcd443
Compare
arbourd
force-pushed
the
update-wasmtime
branch
from
efcd443
to
2f1a5ad
Compare
|
I think we should skip this update... this bundled copy of wasmtime is currently only used by our bespoke libunit-wasm stuff, which is likely an evolutionary dead end over the long run as WASI progresses... |
|
Oh okay @callahad. We'll close out this PR and leave v11 for the time being? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates wasmtime to latest major release
18.0.0as per: #1123 (comment)