Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEMPLATE: Add null/ to .gitignore #3191

Merged
merged 4 commits into from
Oct 10, 2024
Merged

TEMPLATE: Add null/ to .gitignore #3191

merged 4 commits into from
Oct 10, 2024

Conversation

maxulysse
Copy link
Member

include null/ for people that forget outdir

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@maxulysse
Update .gitignore
62ce0c9 
include null/ for people that forget outdir
sateeshperi
sateeshperi previously requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@sateeshperi sateeshperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog plz

@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.38%. Comparing base (16dc3b9) to head (853060b).
Report is 5 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mashehu
mashehu approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add it to the end of the list, to avoid merge conflicts

@maxulysse maxulysse changed the title Update .gitignore TEMPLATE: Add null/ to .gitignore Oct 10, 2024
@maxulysse maxulysse merged commit 3b8cd7f into dev Oct 10, 2024
84 checks passed
@maxulysse maxulysse deleted the maxulysse-patch-5 branch October 10, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

@sateeshperi sateeshperi sateeshperi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @mashehu @sateeshperi