Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify test profiles in CI test #374

Open
LilyAnderssonLee opened this issue Sep 14, 2023 · 1 comment
Open

Simplify test profiles in CI test #374

LilyAnderssonLee opened this issue Sep 14, 2023 · 1 comment
Assignees
@jfy133 @LilyAnderssonLee
Labels
enhancement Improvement for existing functionality
Milestone
1.3.0 - Crazy Corgi

Comments

@LilyAnderssonLee
Copy link
Contributor

Description of feature

As pointed out by @maxulysse in #362, we should simplify the test profiles since the test is already included in the CI tests.
Therefore should we just keep the following test profiles from ci.yml?

  • "test"
  • "test_malt"
  • "test_motus"
  • "test_prinseqplusplus"
@LilyAnderssonLee LilyAnderssonLee added the enhancement Improvement for existing functionality label Sep 14, 2023
@LilyAnderssonLee LilyAnderssonLee self-assigned this Sep 14, 2023
@jfy133
Copy link
Member

jfy133 commented Nov 10, 2023

Yeah this definitely would be helpful to include the base test config and modify off of that, just came across a case where I was modifying test but was actually running test_noprofiling... however the addition I made to test would apply to all the data 😅 - thus makes sense to apply it 'everywhere'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfy133 jfy133

@LilyAnderssonLee LilyAnderssonLee

Labels
enhancement Improvement for existing functionality
Projects
None yet
Milestone
1.3.0 - Crazy Corgi
Development

No branches or pull requests
2 participants
@jfy133 @LilyAnderssonLee