Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time limit of AlevinQC #334

Closed
nictru opened this issue May 29, 2024 · 3 comments · Fixed by #335
Closed

Time limit of AlevinQC #334

nictru opened this issue May 29, 2024 · 3 comments · Fixed by #335
Labels
bug Something isn't working

Comments

@nictru
Copy link
Contributor

nictru commented May 29, 2024

Description of the bug

Currently, the time limit of AlevinQC is hard coded to 120h here since #196 was solved via #197. In my case, this led to Slurm PartitionTimeLimit problems (basically nothing was executed because the time limit of the queue is lower than 120h). Usually one can solve this by setting the max_time parameter. However, this parameter does not affect the AlevinQC time limit.

As an experienced nextflow user, one can easily find a temporary fix through adding this to nextflow.config:

process {
    withName: 'ALEVINQC' {
        time = '5.h'
    }
}

But I think figuring this out might be hard for users with less experience.

Some ideas for a permanent fix:

  • Use the check_max function for setting the limit
  • Assign one of the standard process labels (maybe process_low + process_long) and tell users to perform a manual override of the time limit if they really hit the time limit

I can also open a PR myself, but maybe I am missing something here, so let's discuss first

Command used and terminal output

No response

Relevant files

No response

System information

Slurm
nf-core/scrnaseq version 2.6.0

@nictru nictru added the bug Something isn't working label May 29, 2024
@grst
Copy link
Member

grst commented May 29, 2024

Hi,

this should definitely use the check_max function. PR would be welcome!

@nictru
Copy link
Contributor Author

nictru commented May 29, 2024

Great, will open one later today!

@nictru nictru linked a pull request May 29, 2024 that will close this issue
@grst
Copy link
Member

grst commented Jun 3, 2024

Closed by #335

@grst grst closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants