fix: fix warning with legacy styles in SSR #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Fixes
Contributorswildergd, LeandroTorresSicilia Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
|
Visit the preview URL for this PR (updated for commit 6f4ea9d): https://react-rainbow--pr2140-fix-legacy-styles-a1jxij2h.web.app (expires Thu, 11 Feb 2021 15:30:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Code Climate has analyzed commit 96a0cb6 and detected 0 issues on this pull request. View more on Code Climate. |
LeandroTorresSicilia
approved these changes
Feb 4, 2021
jpetaux
pushed a commit
to jpetaux/react-rainbow
that referenced
this pull request
Jun 27, 2021
* fix: fix warning with legacy styles in SSR * fix: lint issues * fix: issues in comments * fix: lint issues Co-authored-by: Jose Leandro Torres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1471
Changes proposed in this PR:
NOTE:
this will remove warning described in this comment
https://github.com/nexxtway/react-rainbow/issues/1471#issuecomment-765706675. However a new Warning will appearWarning: Expected server HTML to contain a matching <style> in <div>. it is a common warning and research indicates that is not a real problem. So, it can be ignored.@nexxtway/react-rainbow