Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: RelaxedR1CS test isn't complete #288

Open
h-hafezi opened this issue Oct 20, 2024 · 1 comment
Open

[BUG]: RelaxedR1CS test isn't complete #288

h-hafezi opened this issue Oct 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@h-hafezi
Copy link

Program Information

The R1CS test in

for _ in 0..3 {

only checks folding multiple instances of the same r1cs instance/witness in the for loop, such folding doesn't result in any cross-term, despite your construction is correct, your test doesn't check all cases.

Project Information

No response

Reproduction Steps

I'm trying to implement Ova[Bunz] by modifying your code and that's how I realised this...

What is expected?

....

What is actually happening?

again the test doesn't check all cases.

System Information

No response

Any additional comments?

No response

@h-hafezi h-hafezi added the bug Something isn't working label Oct 20, 2024
@nexodon
Copy link

nexodon commented Oct 20, 2024

Thanks @h-hafezi - relieved that this is an inadequate test rather than a bug in the code, but it's very worth noting and getting full coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants