Update installation section #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorlin
changed the title
tsibley
approved these changes
May 29, 2024
There was a problem hiding this comment.
+1 for this polish overall.
I noted that the commits don't particularly say why the change is made. Like, I can hazard some guesses about why the start menu wording was changed (e.g. maybe there are other results for wsl that aren't the right one to pick?), but the reason is definitely not clear. It's really useful for the commit message to contain the why.
genehack
approved these changes
May 29, 2024
It's possible for Ubuntu to not be the default distro. In this case, the error of `curl: not found` can be unhelpful to new users. Add a note explaining how to fix it.
Use the guilabel directive and add names for Windows.
Windows 10/11 comes with a search bar/icon in the task bar that opens the Start menu, so if the user doesn't know what "Start menu" is, the verb "searching" should provide a visual hint.
victorlin
force-pushed
the
victorlin/update-install
branch
from
7f3f5a7
to
cdc6374
Compare
Some users may not have Launchpad in the Dock - it can be easily removed by drag and drop. Spotlight in the menu bar is more universal¹, plus users who know the hotkey (CMD+space) can use it if desired. ¹ it can still be removed with 3rd party apps
This should be a more intuitive flow for new users.
The previous recommendation was to expose the Windows home directory under the WSL directory. I thought this would be a practical approach to the difference in home directories, but I'm not a WSL user so I can't verify that idea. Installing `wslu` is also a bit more complicated nowadays.¹ Instead of a hard recommendation, simply describe the difference in home directories and let the user decide what to do. ¹ <https://wslutiliti.es/wslu/install.html#ubuntu>
victorlin
force-pushed
the
victorlin/update-install
branch
from
cdc6374
to
29f44b9
Compare
victorlin
commented
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview
Description of proposed changes
See commit messages
Related issue(s)
070da40 and 29f44b9 were prompted by debugging in the lab. The rest is stuff that I thought of while re-reading the contents.
Checklist