Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Support native osx-arm64 conda install #77

Open
24 of 28 tasks
corneliusroemer opened this issue Jul 10, 2024 · 5 comments · May be fixed by #80
Open
24 of 28 tasks

ENH: Support native osx-arm64 conda install #77

corneliusroemer opened this issue Jul 10, 2024 · 5 comments · May be fixed by #80
Labels
enhancement New feature or request

Comments

@corneliusroemer
Copy link
Member

corneliusroemer commented Jul 10, 2024

Context

Now that bioconda supports osx-arm64, we can finally try to make a native environment, which will speed up local builds by around a factor of 2.

There's quite a lot of work to do: all our dependencies will need to be supported by osx-arm64, but it should be doable!

This issue is a tracker, to help us see what's still missing.

Tasks

@corneliusroemer corneliusroemer added the enhancement New feature or request label Jul 10, 2024
@jameshadfield
Copy link
Member

Are we still missing tsv-utils which is osx-64/linux-64?

- tsv-utils

@corneliusroemer
Copy link
Member Author

@jameshadfield no 😀 I migrated it to conda-forge a few days ago as it's of general utility and not bio limited. check it out at conda-forge/tsv-utils

@victorlin
Copy link
Member

victorlin commented Jul 12, 2024

There are two stages here - the first one is making sure that dependencies can be installed natively which looked like a big undertaking, thank you for taking care of that!

Next, we have to update the build to produce the package for osx-arm64. I think this is what needs to be done:

  1. Use osx-arm64 here:
    Darwin/arm64)
    echo "osx-64";;
  2. Use macos-14 here:
    build-and-test:
    needs: generate-version
    strategy:
    fail-fast: false
    matrix:
    os:
    - ubuntu-22.04
    - macos-12

For (2) I think we'll want to append to the list rather than replace macos-12 so that there will still be a native package for Intel Macs.

@corneliusroemer
Copy link
Member Author

Nice @victorlin - I didn't see this comment of yours just now but came to the same conclusions when trying a PR. I've made one here:

It turns out that gzip isn't yet available for osx-arm64. We could potentially drop that for osx-arm64 as gzip is available from the system on macOS arm64.

But I made a migration pr to conda-forge anyways:

@corneliusroemer corneliusroemer linked a pull request Jul 12, 2024 that will close this issue
3 tasks
@victorlin
Copy link
Member

@corneliusroemer let me know if you need any help pushing #80 through. I've prioritized task under my name at our biweekly priorities meetings because it seems close to done, and I think it'd be great to take advantage of all the work that you and others have done to make it possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants