Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write-envdir: Explicitly error with a better message when a requested var is unset #87

Merged
merged 1 commit into from
May 22, 2024

Conversation

tsibley
Copy link
Member

@tsibley tsibley commented May 22, 2024

Eventually I'll dust off my WIP for nextstrain write-envdir which does this sort of nicety and more, and this Bash program will become obsolete.

Checklist

  • Checks pass

… var is unset

Eventually I'll dust off my WIP for `nextstrain write-envdir` which does
this sort of nicety and more, and this Bash program will become
obsolete.
@tsibley
Copy link
Member Author

tsibley commented May 22, 2024

Testing this in actual context results in a better error message:

mkdir: created directory '.git/nextstrain/env.d'
Wrote .git/nextstrain/env.d/AWS_ACCESS_KEY_ID
Wrote .git/nextstrain/env.d/AWS_SECRET_ACCESS_KEY
error: AWS_SESSION_TOKEN is not set

@tsibley tsibley requested a review from a team May 22, 2024 21:42
@tsibley tsibley merged commit 0432ba2 into master May 22, 2024
38 checks passed
@tsibley tsibley deleted the trs/write-envdir/error-on-unset branch May 22, 2024 21:44
Copy link
Member

@victorlin victorlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants