-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store checksum of previous migration in each migration #29
Comments
Great! I was thinking about similar solution of storing such thing into separate file... :) |
👍 It would be handy to have a Also it can't be integrated into old migrations easily as their checksum would change. |
I have a different idea. What we want is the security, that prevent's us from merging pull request if it contains migrations which is not the last. Such check may be done by CI server that run your test suite on the merge commit. However, the current proposed solution does not solve this, if the test suite (and migraiton command) is not run on the merge, just on the head of branch (=current CircleCI's behavior). My idea is the following: What do you think? |
That would work, but it could lead to false sense of security with git rerere enabled (it would resolve the conflict but keep the new migration not-rebased). Other than that I don't see a problem. |
The
migrations:create
command would instead of empty file create file with first line containing reference to parent migration, e.g. sth like# parent = structures/2015-08-28-142150-init.sql/786340a54b68591563e983f60f82fecc
This will allow us to detect when programmer forgot to „rebase migrations“. This would also probably required some tool to help with the rebasing etc.
The text was updated successfully, but these errors were encountered: