Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nextflow install path #5198

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update nextflow install path #5198

wants to merge 6 commits into from

Conversation

christopher-hakkaart
Copy link
Contributor

  • Update nextflow install path
  • Update NXF_VER example

@christopher-hakkaart
Update install path
0f9e791 
Signed-off-by: christopher-hakkaart <[email protected]>
@netlify Netlify
Copy link

netlify bot commented Aug 2, 2024 •
edited
Loading

✅ Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit f987a32
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/66d962490765060008cd4c76
😎 Deploy Preview https://deploy-preview-5198--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@christopher-hakkaart
Update NXF_VER example
186560e 
Signed-off-by: christopher-hakkaart <[email protected]>
pditommaso
pditommaso reviewed Aug 5, 2024
View reviewed changes
docs/install.md

```bash
sudo mv nextflow /usr/local/bin
mv nextflow $HOME/.local/bin/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this, because $HOME/.local/bin is not a standard path. Mac does not have it (not sure across different linux distribution).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - it would be nice to have a suggested path rather than saying "Install on your path". Do you have any suggestions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it can be fixed adding mkdir -p $HOME/.local/bin/ before mv

and changing the tip something like:

make sure the directory $HOME/.local/bin/ is in your PATH variable, otherwise .. (how to do it). Alternatively you can use any other directory already in your path. Be aware nextflow will try to override this file when upgrading it, etc ..

@christopher-hakkaart christopher-hakkaart marked this pull request as ready for review September 5, 2024 10:50
@christopher-hakkaart christopher-hakkaart requested a review from a team as a code owner September 5, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pditommaso pditommaso pditommaso left review comments

@bentsherman bentsherman bentsherman approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christopher-hakkaart @pditommaso @bentsherman