-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Usage of pushToHistory function on prev/next #2605
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
requested review from
susnux and
skjnldsv
and removed request for
susnux
November 4, 2024 10:50
artonge
added
bug
Something isn't working
3. to review
Waiting for reviews
javascript
Javascript related ticket
labels
Nov 4, 2024
/backport to stable30 |
/backport to stable29 |
/backport to stable28 |
artonge
force-pushed
the
artonge/fix/prev_next_push_to_history
branch
from
November 4, 2024 10:53
485844f
to
41adf04
Compare
susnux
reviewed
Nov 4, 2024
susnux
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a stylistic comment
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/prev_next_push_to_history
branch
from
November 4, 2024 16:14
41adf04
to
fa350fd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
backport-request
Pending backport by the backport-bot
bug
Something isn't working
javascript
Javascript related ticket
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2567