fix: Fix error when viewing current version #2584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in text cypress tests:
Steps to reproduce:
Before this change we had an error thrown:
Honestly I'm not sure where exactly to fix this best, but this seemed like the smallest change that wouldn't cause further side effects.
Viewer previously assumed a string for the share attributes however the fileInfo that the files app passes along through the version sidebar is holding an array as the JSON string is parsed in https://github.com/nextcloud/server/blob/d537050f19b264f96d86a564770835ae36ab9add/core/src/files/client.js#L398-L408