Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Correctly create built asset libraries #2546

Merged
merged 2 commits into from
Sep 17, 2024
Merged

chore: Correctly create built asset libraries #2546

merged 2 commits into from
Sep 17, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 17, 2024

No description provided.

@susnux susnux added the 3. to review Waiting for reviews label Sep 17, 2024
@skjnldsv
Copy link
Member

/compile

@nextcloud-command
chore(assets): Recompile assets
485ee9e 
Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux merged commit ef96df1 into master Sep 17, 2024
29 checks passed
@susnux susnux deleted the fix/proper-asset-license branch September 17, 2024 23:26
@AndyScherzinger
Copy link
Member

@susnux js\logger-CYBBkF-8.chunk ships a incompatible license ID: GPL-3.0 which lack a -only or -or-later suffix. Something to fix in our lib or override since it is an external one?

@AndyScherzinger
Copy link
Member

Fixed via release... #2547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @skjnldsv @AndyScherzinger @nextcloud-command