fix: Load preview URL for download-disabled shares #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions This is not only a possibility for public shares but also for internal shares, the current code only "checked" public shares. This adds the same logic we use in the files app. Probably something to move to `@nextcloud/sharing` but for the moment lets just reuse here. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
This was possible on Nextcloud 30 and previous due to a "bug": The `download` permission was simply not rejected for public shares, just a `hide` flag was set on the public share. Now the permissions are correctly set, so loading a preview is not possible. The work-around is to allow previews when the correct header is set. Signed-off-by: Ferdinand Thiessen <[email protected]>
4 tasks
skjnldsv
force-pushed
the
fix/hide-download-correctly
branch
2 times, most recently
from
8f0dfcc
to
4263b72
Compare
nextcloud-command
force-pushed
the
fix/hide-download-correctly
branch
from
4263b72
to
86f71c2
Compare
skjnldsv
force-pushed
the
fix/hide-download-correctly
branch
from
86f71c2
to
8659a4c
Compare
An error occurred while trying to automatically change base from
fix/hide-download-correctly
to
master
September 15, 2024 10:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was possible on Nextcloud 30 and previous due to a "bug": The
downloadpermission was simply not rejected for public shares, just ahideflag was set on the public share.Now the permissions are correctly set, so loading a preview is not possible. The work-around is to allow previews when the correct header is set.