Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NcVue to v8.6.2 #2157

Closed
wants to merge 3 commits into from
Closed

Bump NcVue to v8.6.2 #2157

wants to merge 3 commits into from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Feb 8, 2024

@ShGKme ShGKme added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Feb 8, 2024
@ShGKme ShGKme self-assigned this Feb 8, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Feb 8, 2024

@skjnldsv Cypress tests are always #ff0000 on viewer, and for me it is always non-obious if it is related. Can we merge both PRs and fix Cypress later if they are related?

Same for the backport.

@skjnldsv
Copy link
Member

skjnldsv commented Feb 8, 2024

Only sharing/download-share-disabled.cy.ts is failing on master it seems, haven't took the time to fix them for now.

@Pytal Pytal mentioned this pull request Feb 8, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Feb 9, 2024

/compile amend

Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@ShGKme
Copy link
Contributor Author

ShGKme commented Mar 1, 2024

Done in #2181

@ShGKme ShGKme closed this Mar 1, 2024
@skjnldsv skjnldsv deleted the deps/nextcloud/vue-8.6.2 branch September 14, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants