Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid issues when switching between versions #1851

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 10, 2023

Improve check if the opened file is the same since there might be different conditions now with version browsing where the fileid remains, therefore we continue checking on the mtime and source to detect if the file rendering component should be refreshed

@juliusknorr
Copy link
Member Author

/backport to stable27

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Aug 10, 2023
@juliusknorr
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr
Copy link
Member Author

All known failures according to the failure rate of master

@juliusknorr juliusknorr merged commit e469438 into master Aug 10, 2023
21 of 27 checks passed
@juliusknorr juliusknorr deleted the bugfix/version-nagivate branch August 10, 2023 10:12
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@juliusknorr
Copy link
Member Author

/backport e1f2c85 to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants