Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video can't be displayed in fullscreen #2415

Closed
alexanderdd opened this issue Aug 12, 2024 · 2 comments
Closed

video can't be displayed in fullscreen #2415

alexanderdd opened this issue Aug 12, 2024 · 2 comments
Assignees
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working design Related to the design regression Regression of a previous working feature

Comments

@alexanderdd
Copy link

alexanderdd commented Aug 12, 2024

To Reproduce
Steps to reproduce the behavior:

  1. in Talk in the browser (Firefox 129.0), open a Talk recording (webm)
  2. Click on fullscreen button
  3. it goes to fullscreen for the blink of an eye
  4. goes back to normal view

Expected behavior
fullscreen mode works

Details
This is on cloud.nextcloud.com

NC 30.0.0 beta 5

can't check viewer version

Maybe related: #2372 and #1037

Browser console

21:06:48.715 Uncaught TypeError: document.body.querySelector(...) is null
    NextJS 2
viewer-main.mjs:122040:23

Edit
there is also this other fullscreen view that you can toggle in the top right ...-menu in the Talk window. Then the video is still not fullscreen, but bigger than before. But there are also problems with this view (should I open a separate issue for this?):

  • title of video overlapping the icons at the top
  • top right controls are overlapping and cannot be used properly

Bildschirmfoto vom 2024-08-12 21-50-48

@alexanderdd alexanderdd added bug Something isn't working regression Regression of a previous working feature 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Aug 12, 2024
@skjnldsv skjnldsv self-assigned this Aug 14, 2024
@alexanderdd
Copy link
Author

alexanderdd commented Sep 23, 2024

@skjnldsv I can reproduce on c.nc.com on NC30.0.0
(both ways of doing fullscreen, as described above, don't work properly)

can you remove "needs triage"?

@alexanderdd alexanderdd added the design Related to the design label Sep 23, 2024
@alexanderdd
Copy link
Author

This is fixed in 30.0.1 (cloud.nextcloud.com)

Feel free to reopen if anyone experiences this for lower versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working design Related to the design regression Regression of a previous working feature
Projects
None yet
Development

No branches or pull requests

2 participants