Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(public): Use @nextcloud/sharing to detect public shares #6339

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix(public): Use @nextcloud/sharing to detect public shares #6339

merged 2 commits into from
Sep 10, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 9, 2024 •
edited
Loading

Fixes: #6324

Depends on:

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

@mejo- mejo- added tests If you write them we ♥ you 2. developing labels Sep 9, 2024
@mejo- mejo- added this to the Nextcloud 31 milestone Sep 9, 2024
@mejo- mejo- self-assigned this Sep 9, 2024
@mejo- mejo- force-pushed the fix/detect_public branch 2 times, most recently from 65b1582 to 275e23c Compare September 9, 2024 14:44
@mejo- mejo- marked this pull request as ready for review September 9, 2024 18:01
max-nextcloud
max-nextcloud approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Happy that we are using @nextcloud/sharing rather than extracting the info from the page ourselves.

@max-nextcloud
Copy link
Collaborator

image
ImageView native attachment specs are failing. Looks like this might also be related.

@mejo-
Copy link
Member Author

mejo- commented Sep 10, 2024

ImageView native attachment specs are failing. Looks like this might also be related.

This is another unrelated failure that already existed before the changes on server 31. These tests are also failing on stable30.

@mejo- mejo- merged commit cfd7986 into main Sep 10, 2024
61 of 63 checks passed
@mejo- mejo- deleted the fix/detect_public branch September 10, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@susnux susnux Awaiting requested review from susnux

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees

@mejo- mejo-

Labels
3. to review tests If you write them we ♥ you
Projects
📝 Office team
Status: ☑️ Done
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

[Nextcloud 31] Text does not work on public shares
2 participants
@mejo- @max-nextcloud