Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mention): No extra whitespace in markdown before/after mentions #6315

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 4, 2024

Fixes: #6314

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

@mejo- mejo- added bug Something isn't working 3. to review labels Sep 4, 2024
@mejo- mejo- added this to the Nextcloud 31 milestone Sep 4, 2024
@mejo- mejo- self-assigned this Sep 4, 2024
@mejo-
Copy link
Member Author

mejo- commented Sep 4, 2024

/backport to stable30

@mejo-
Copy link
Member Author

mejo- commented Sep 4, 2024

/backport to stable29

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me... just needs to remove the .only in the tests to make sure the other tests still run.

src/tests/markdown.spec.js Outdated Show resolved Hide resolved
src/tests/markdown.spec.js Outdated Show resolved Hide resolved
@mejo- mejo- merged commit 19951d5 into main Sep 5, 2024
58 of 61 checks passed
@mejo- mejo- deleted the fix/mention_whitespace branch September 5, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

mentions extra spaces
3 participants