Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/sync error cleanup #6202

Closed
wants to merge 6 commits into from
Closed

fix/sync error cleanup #6202

wants to merge 6 commits into from

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Aug 13, 2024

  • Refactor the general sync state into a defined data strcuture by splitting push/sync/save state and also remembering last success/failure time, number of failures. That way we have more control to show errors only if the issue persists and not immediately on flaky connections
  • Indicate that local changes were not pushed to the server with a proper error message on the save indicator
    • Figure out if we can auto retry the push or if we want to let the user manually trigger it
  • Avoid immediately setting the editor to read only
  • Avoid saving the file as the user if there are unpushed steps
  • Warn users when navigating away with unpushed steps
  • File follow up issue for proper offline support, keeping changes in the browser storage and pushing later

📝 Summary

  • Resolves: #

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@juliushaertl
Copy link
Member Author

Closing until further discussed during the contributor week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant