Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] Cleanup _oc_webroot stubs where possible #5841

Merged
merged 5 commits into from
May 28, 2024
Merged

[stable29] Cleanup _oc_webroot stubs where possible #5841

merged 5 commits into from
May 28, 2024

Commits on May 28, 2024

  1. test(jest): remove internal _oc_webroot stub 

    We do not need to test functionality internal to `@nextcloud/router`.

Signed-off-by: Max <[email protected]>
    @max-nextcloud @backportbot
    max-nextcloud authored and backportbot[bot] committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d361fd0 View commit details
    Browse the repository at this point in the history

  2. test(cy): introduce cy.prepareWindowForSessionApi 

    * Prevent @nextcloud/router from reading `window.location.pathname`
  which would include `cypress/_iframe`.
* Keep the `window.OC` stub for now for easier backports.
  Tests pass without it these days.

Signed-off-by: Max <[email protected]>
    @max-nextcloud @backportbot
    max-nextcloud authored and backportbot[bot] committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f295446 View commit details
    Browse the repository at this point in the history

  3. test(cy): refactor to use aliases 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud @backportbot
    max-nextcloud authored and backportbot[bot] committed May 28, 2024
    Configuration menu
    Copy the full SHA
    169b803 View commit details
    Browse the repository at this point in the history

  4. test(cy): introduce cy.sessionUsers() for users endpoint 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud @backportbot
    max-nextcloud authored and backportbot[bot] committed May 28, 2024
    Configuration menu
    Copy the full SHA
    615c4b3 View commit details
    Browse the repository at this point in the history

  5. test(api): split test and use .its and .should 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud @backportbot
    max-nextcloud authored and backportbot[bot] committed May 28, 2024
    Configuration menu
    Copy the full SHA
    2a4d984 View commit details
    Browse the repository at this point in the history