fix(session): Fix setting a guest name #5469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable28 |
|
/backport to stable27 |
mejo-
force-pushed
the
fix/set_guestname
branch
from
0477753
to
1d067b7
Compare
max-nextcloud
approved these changes
Mar 13, 2024
|
We should really have a cypress test for this as it's something we do not often test during our daily routine. |
Agreed, added one now. |
mejo-
force-pushed
the
fix/set_guestname
branch
from
1d067b7
to
4dfcbfc
Compare
Fixes: #4252 Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/set_guestname
branch
from
4dfcbfc
to
b227be0
Compare
juliushaertl
approved these changes
Mar 13, 2024
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4252
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)