fix(backend): Accept pushs with only step1 messages by read-only clients #5466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
fix/read_only_pushs
branch
from
f55a15b
to
1302736
Compare
juliusknorr
reviewed
Mar 12, 2024
juliusknorr
approved these changes
Mar 12, 2024
mejo-
force-pushed
the
fix/read_only_pushs
branch
2 times, most recently
from
0e08405
to
dc268a9
Compare
This fixes read-only clients getting 403 responses on push requests that only contain questions for updates. Fixes: #5223 Fixes: #5366 Fixes: #5368 Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/read_only_pushs
branch
from
dc268a9
to
a43d77c
Compare
Signed-off-by: Jonas <[email protected]>
|
/backport to stable28 |
|
/backport to stable27 |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This fixes read-only clients getting 403 responses on push requests that only contain questions for updates.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)