Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable nested embedding fully #5439

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 6, 2024

We want to prevent nesting interactive widgets, so this will ensure that we know about that text is rendered as an embedding with nextcloud/server#44012

Follow up to check

  • Check if we can just use inject in the paragraph component if we use the viewer vue instance

@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Mar 6, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Mar 6, 2024

One would argue that this is not an official Viewer prop yet 🙈
But it make sense, we'll need to consider this for Viewer 3

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor comments. One of them might point at a conceptual issue though... Do we want to render the previews inside embedded content non-interactive or not at all?

If we don't render the Preview nothing will be shown - not even the embedded link. So maybe we leave out the Preview nodes all together then and at least show the link?

src/nodes/Preview.vue Outdated Show resolved Hide resolved
src/EditorFactory.js Show resolved Hide resolved
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr juliusknorr merged commit 885810e into main Mar 7, 2024
53 of 57 checks passed
@juliusknorr juliusknorr deleted the fix/handle-is-embedded branch March 7, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants