fix(links): Insert /f/<fileId> format for links to files
#5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
fix/link_to_files
branch
4 times, most recently
from
a18314e
to
4c6c5c3
Compare
Get rid of the old `/path/?fileId=<id>` format. It never really worked anyway because the paths were relative to the users' home directory. Instead, insert links to files/folders as full URLs with the `/f/<fileId>` format. This makes link previews work both in Text and Collectives. Rewrite links in the old format to the new format. But don't touch absolute link (without origin) to the collectives app to not break collectives-specific link handling to other pages. Signed-off-by: Jonas <[email protected]>
See discussions here for further information: * nextcloud-libraries/nextcloud-vue#5290 * nextcloud-libraries/nextcloud-vue#5272 Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/link_to_files
branch
from
4c6c5c3
to
ddb163b
Compare
juliushaertl
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Get rid of the old
/path/?fileId=<id>format. It never really worked anyway because the paths were relative to the users' home directory.Instead, insert links to files/folders as full URLs with the
/f/<fileId>format. This makes link previews work both in Text and Collectives.Rewrite links in the old format to the new format. But don't touch absolute link (without origin) to the collectives app to not break collectives-specific link handling to other pages.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)