Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] Hide share and close buttons on direct editing for desktop #5099

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Dec 7, 2023

πŸ“ Summary

Backport PR for #4346

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Signed-off-by: Luka Trovic <[email protected]>
@luka-nextcloud luka-nextcloud self-assigned this Dec 7, 2023
@juliushaertl juliushaertl changed the title [Backport to 27] Hide share and close buttons on direct editing for desktop [stable27] Hide share and close buttons on direct editing for desktop Dec 7, 2023
@juliushaertl juliushaertl added bug Something isn't working 3. to review labels Dec 7, 2023
@juliushaertl juliushaertl added this to the Nextcloud 27.1.5 milestone Dec 7, 2023
@juliushaertl
Copy link
Member

@luka-nextcloud I renamed the title to match our common pattern there. Please also assign labels and the next milestone for the relevant stable release.

@juliushaertl
Copy link
Member

And reference the original pr in the description to have the reference back to it

@luka-nextcloud luka-nextcloud added the backported successfully backported label Dec 7, 2023
@juliushaertl
Copy link
Member

/compile

Signed-off-by: nextcloud-command <[email protected]>
@juliushaertl juliushaertl merged commit 5175811 into stable27 Dec 7, 2023
23 of 24 checks passed
@juliushaertl juliushaertl deleted the backport/feature/hide-share-and-close-buttons-on-direct-editing-stable27 branch December 7, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review backported successfully backported bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants