Revert "tmp: skip known attachment failures" #4904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
force-pushed
the
revert/test-skip-2
branch
from
f37a492
to
2a15edc
Compare
This reverts commit 66d5c7d. Signed-off-by: Julius Härtl <[email protected]>
juliushaertl
force-pushed
the
revert/test-skip-2
branch
from
2a15edc
to
8a0bfb4
Compare
Signed-off-by: Julius Härtl <[email protected]>
juliushaertl
force-pushed
the
revert/test-skip-2
branch
from
b3783dc
to
c5ea735
Compare
mejo-
approved these changes
Nov 30, 2023
|
/backport to stable28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 66d5c7d
Further commit fixes the tests, isolates them a bit more and moves file operations from clicking through UI to actual API calls.