Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] Avoid loading the image before the node view #4718

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

max-nextcloud
Copy link
Collaborator

📝 Summary

Backport of #2675

Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
Signed-off-by: Max <[email protected]>
@max-nextcloud
Copy link
Collaborator Author

/compile

Signed-off-by: nextcloud-command <[email protected]>
@max-nextcloud max-nextcloud changed the title Avoid loading the image before the node view [stable23] Avoid loading the image before the node view Aug 21, 2023
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Not covered by cypress tests it seems (we only have 14 at all in 23 🙈)

Didn't test, let me know if I shall give it a quick spin

@max-nextcloud
Copy link
Collaborator Author

Didn't test, let me know if I shall give it a quick spin

I tested locally myself. Should be fine.

@juliushaertl juliushaertl added bug Something isn't working 4. to release labels Aug 29, 2023
@juliushaertl juliushaertl merged commit db482da into stable23 Aug 29, 2023
12 checks passed
@juliushaertl juliushaertl deleted the backport/stable23/2675 branch August 29, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants