Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @nextcloud/dialogs to v5 (main) - autoclosed #4703

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 19, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@nextcloud/dialogs ^4.1.0 -> ^5.0.0-beta.1 age adoption passing confidence

Release Notes

nextcloud-libraries/nextcloud-dialogs (@​nextcloud/dialogs)

v5.0.0-beta.1

Compare Source

💥 Breaking
  • A Vue based file picker is provided which uses @nextcloud/vue version 8, so this library will only work on Nextcloud 28+
  • Modernize FilePickerBuilder to directly make use of the Vue based file picker #​904 (@​susnux)
    • This slightly breaks the FilePickerBuilder API:
      • FilePicker.pick now returns a Promise resolving to string[] containing the picked paths
      • FilePicker.constructor parameter order was changed
      • FilePickerBuilder.setModal was removed as it has no effect
      • FilePickerBuilder.setType is deprecated in favor of FilePickerBuilder.addButton
      • FilePickerBuilder.addButton was added which allows to add custom buttons with callbacks on click (so users can now distinguish which button was clicked)
🚀 Enhancement
  • A Vue based FilePicker component was added, which can be used either as a component or using programmatically #​878 (@​susnux)
  • FilePickerBuilder: Allow to add custom buttons #​896 (@​susnux)
🐛 Fixed bugs
Changed
  • The package does no longer contain core-js polyfills as Nextcloud core already provides polyfills #​863 (@​susnux)
  • The project was moved to a new Github organization (nextcloud-libraries)
  • Add version compatibility section to README #​891 (@​susnux)
  • Improved developer documentation #​906 (@​susnux)
  • Dependency updates

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Aug 19, 2023
@renovate renovate bot requested review from a team, mejo- and max-nextcloud and removed request for a team August 19, 2023 04:22
@cypress
Copy link

cypress bot commented Aug 19, 2023

66 failed and 1 flaky tests on run #11764 ↗︎

66 45 2 38 Flakiness 1

Details:

fix(deps): update dependency @nextcloud/dialogs to v5 (main)
Project: Text Commit: 6a6cbae63d
Status: Failed Duration: 11:19 💡
Started: Aug 19, 2023 4:28 AM Ended: Aug 19, 2023 4:40 AM
Failed  workspace.spec.js • 15 failed tests

View Output Video

Test Artifacts
Workspace > Hides the workspace when switching to another folder Output Screenshots
Workspace > Hides the workspace when switching to another view Output Screenshots
Workspace > adds a Readme.md Output Screenshots
Workspace > formats text Output Screenshots
Workspace > creates headings via submenu Output Screenshots
Workspace > creates lists Output Screenshots
Workspace > takes README.md into account Output Screenshots
Workspace > emoji picker Output Screenshots
Workspace > relative folder links Output Screenshots
Workspace > callouts > create callout Output Screenshots
The first 10 failed tests are shown, see all 15 tests in Cypress Cloud.
Failed  attachments.spec.js • 10 failed tests

View Output Video

Test Artifacts
Test all attachment insertion methods > See test files in the list and display hidden files Output Screenshots
Test all attachment insertion methods > Insert an image file from Files Output Screenshots
Test all attachment insertion methods > Upload a local image file (table.png) Output Screenshots
Test all attachment insertion methods > Upload a local media file (file.txt.gz) Output Screenshots
Test all attachment insertion methods > Upload image files with the same name Output Screenshots
Test all attachment insertion methods > test if attachment files are in the attachment folder Output Screenshots
Test all attachment insertion methods > test if attachment folder is moved with the markdown file Output Screenshots
Test all attachment insertion methods > test if attachment folder is copied when copying a markdown file Output Screenshots
Test all attachment insertion methods > test if attachment folder is deleted after having deleted a markdown file Output Screenshots
Test all attachment insertion methods > [share] check everything behaves correctly on the share target user side Output Screenshots
Failed  sections.spec.js • 6 failed tests

View Output Video

Test Artifacts
Content Sections > Heading anchors > Anchor exists Output Screenshots
Content Sections > Heading anchors > Anchor ID is updated Output Screenshots
Content Sections > Heading anchors > scrolls anchor into view Output Screenshots
Content Sections > Heading anchors > Can change heading level Output Screenshots
Content Sections > Table of Contents > sidebar toc Output Screenshots
Content Sections > Table of Contents > empty toc Output Screenshots
Failed  conflict.spec.js • 6 failed tests

View Output Video

Test Artifacts
text/plain (lines.txt) > displays conflicts Output Screenshots
text/plain (lines.txt) > resolves conflict using current editing session Output Screenshots
text/plain (lines.txt) > resolves conflict using server version Output Screenshots
text/markdown (test.md) > displays conflicts Output Screenshots
text/markdown (test.md) > resolves conflict using current editing session Output Screenshots
text/markdown (test.md) > resolves conflict using server version Output Screenshots
Failed  share.spec.js • 2 failed tests

View Output Video

Test Artifacts
Open test.md in viewer > Shares the file as a public read only link Output Screenshots
Open test.md in viewer > Share a file with download disabled shows an error Output Screenshots

The first 5 failed specs are shown, see all 18 specs in Cypress Cloud.

Flakiness  cypress/e2e/api/SyncServiceProvider.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync service provider > recovers from a dropped message Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@renovate renovate bot changed the title fix(deps): update dependency @nextcloud/dialogs to v5 (main) fix(deps): update dependency @nextcloud/dialogs to v5 (main) - autoclosed Aug 24, 2023
@renovate renovate bot closed this Aug 24, 2023
@renovate renovate bot deleted the renovate/main-nextcloud-dialogs-5.x branch August 24, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants