Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(cypress): Make sure to build before cypress #4667

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 11, 2023

To have cypress tests running against the actual latest state

@cypress
Copy link

cypress bot commented Aug 11, 2023

Passing run #11706 ↗︎

0 149 2 0 Flakiness 0

Details:

ci(cypress): Make sure to build before cypress
Project: Text Commit: f4b0fcce5b
Status: Passed Duration: 05:30 💡
Started: Aug 17, 2023 3:25 PM Ended: Aug 17, 2023 3:30 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@max-nextcloud
Copy link
Collaborator

ouch... yes - we should really do this. I think we also lost it in 27. I wonder how we can prevent overwriting this in the future again.

@juliusknorr
Copy link
Member Author

We should at some point just switch to the shared workflow template, but that needs some work first

@juliusknorr juliusknorr added bug Something isn't working tests If you write them we ♥ you 3. to review labels Aug 17, 2023
@juliusknorr
Copy link
Member Author

/backport to stable27

@juliusknorr juliusknorr merged commit 995fbfa into main Aug 18, 2023
36 checks passed
@juliusknorr juliusknorr deleted the fix/cypress-npm-build branch August 18, 2023 07:35
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working tests If you write them we ♥ you
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants