Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid unnecessary local translate function #4664

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Aug 10, 2023

Avoid warnings in dev builds browser console as we have a global registration of t() anyways.

@juliushaertl juliushaertl added bug Something isn't working 3. to review labels Aug 10, 2023
@juliushaertl juliushaertl added this to the Nextcloud 28 milestone Aug 10, 2023
@cypress
Copy link

cypress bot commented Aug 10, 2023

Passing run #11639 ↗︎

0 149 2 0 Flakiness 0

Details:

fix: Avoid unnecessary local translate function
Project: Text Commit: cb8980263f
Status: Passed Duration: 04:52 💡
Started: Aug 10, 2023 5:04 PM Ended: Aug 10, 2023 5:09 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch.

@juliushaertl
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <[email protected]>
@juliushaertl juliushaertl merged commit df2a3df into main Aug 10, 2023
31 checks passed
@juliushaertl juliushaertl deleted the fix/duplicate-t branch August 10, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants