Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly handle viewer loading in collectives #4657

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 9, 2023

  • Fix emitting the loaded state in all cases
  • Rework check for source based read only view to explicitly limit on versions or files with source only (without a file id)

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress
Copy link

cypress bot commented Aug 9, 2023

1 flaky tests on run #11599 ↗︎

0 149 2 0 Flakiness 1

Details:

fix: Properly handle viewer loading in collectives
Project: Text Commit: 549efefc71
Status: Passed Duration: 04:22 💡
Started: Aug 9, 2023 8:17 AM Ended: Aug 9, 2023 8:21 AM
Flakiness  cypress/e2e/api/SyncServiceProvider.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync service provider > recovers from a dropped message Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tackling this!

@mejo-
Copy link
Member

mejo- commented Aug 9, 2023

/compile

Signed-off-by: nextcloud-command <[email protected]>
@mejo- mejo- merged commit 2716cfd into main Aug 9, 2023
31 checks passed
@mejo- mejo- deleted the bugfix/noid/viewer-loading-collectives branch August 9, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants