-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use default font size #4644
Conversation
Signed-off-by: Julius Härtl <[email protected]>
1 flaky tests on run #11530 ↗︎
Details:
cypress/e2e/sync.spec.js • 1 flaky test
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Probably should be backported to stable26 and stable27. |
The cypress failure is a 401 unauthorized during the validation of the session. We've seen this from time to time happening on random tests. |
/compile |
Signed-off-by: nextcloud-command <[email protected]>
/backport 1bccffc to stable27 |
/backport 1bccffc to stable26 |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/backport 662f78b to stable27 |
/backport 662f78b to stable26 |
📝 Summary
As brought up in #4024 (comment) apparently we were using 14px as font size for the editor while the default font size should be 15px these days. Let's switch to using the css variable to be flexible with this in the future, as I remember some discussion around switching to 16px.
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)