Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use default font size #4644

Merged
merged 2 commits into from
Aug 7, 2023
Merged

fix: Use default font size #4644

merged 2 commits into from
Aug 7, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 7, 2023

📝 Summary

As brought up in #4024 (comment) apparently we were using 14px as font size for the editor while the default font size should be 15px these days. Let's switch to using the css variable to be flexible with this in the future, as I remember some discussion around switching to 16px.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Signed-off-by: Julius Härtl <[email protected]>
@cypress
Copy link

cypress bot commented Aug 7, 2023

1 flaky tests on run #11530 ↗︎

0 149 2 0 Flakiness 1

Details:

fix: Use default font size
Project: Text Commit: 1bccffc652
Status: Passed Duration: 03:51 💡
Started: Aug 7, 2023 1:19 PM Ended: Aug 7, 2023 1:23 PM
Flakiness  cypress/e2e/sync.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync > passes the doc content from one session to the next Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo-
Copy link
Member

mejo- commented Aug 7, 2023

Probably should be backported to stable26 and stable27.

@max-nextcloud
Copy link
Collaborator

The cypress failure is a 401 unauthorized during the validation of the session. We've seen this from time to time happening on random tests.

@mejo-
Copy link
Member

mejo- commented Aug 7, 2023

/compile

Signed-off-by: nextcloud-command <[email protected]>
@mejo- mejo- merged commit 4d9ae39 into main Aug 7, 2023
31 checks passed
@mejo- mejo- deleted the bugfix/noid/default-font-size branch August 7, 2023 13:25
@mejo-
Copy link
Member

mejo- commented Aug 7, 2023

/backport 1bccffc to stable27

@mejo-
Copy link
Member

mejo- commented Aug 7, 2023

/backport 1bccffc to stable26

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mejo-
Copy link
Member

mejo- commented Aug 7, 2023

/backport 662f78b to stable27

@mejo-
Copy link
Member

mejo- commented Aug 7, 2023

/backport 662f78b to stable26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants