fix(mentions): encode user id in mentions URLs #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whitespaces in the URL of mentions break markdown parsing, which leads to unrendered mentions for users with a whitespace in their userId. Fixes: #4157 Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/mentions_encode_userid
branch
from
814ed3e
to
63b05d2
Compare
max-nextcloud
approved these changes
Jul 27, 2023
1 flaky tests on run #11326 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Text and server mimetypes > handle plaintext in a pre tag |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
/compile |
|
/backport 63b05d2 to stable27 |
|
/backport 63b05d2 to stable26 |
Signed-off-by: nextcloud-command <[email protected]>
This was referenced Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitespaces in the URL of mentions break markdown parsing, which leads to unrendered mentions for users with a whitespace in their userId.
Fixes: #4157
Todo
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)