Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace invalid sass rules with correct ones #4345

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 22, 2023

📝 Summary

Replace invalid combinators, for reference see https://sass-lang.com/documentation/breaking-changes/bogus-combinators

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress
Copy link

cypress bot commented Jun 22, 2023

1 failed and 3 flaky tests on run #10415 ↗︎

1 143 1 3 Flakiness 3

Details:

fix: Replace invalid sass rules with correct ones
Project: Text Commit: e806141296
Status: Failed Duration: 03:37 💡
Started: Jun 22, 2023 5:28 PM Ended: Jun 22, 2023 5:32 PM
Failed  cypress/e2e/viewer.spec.js • 1 failed test

View Output Video

Test Artifacts
Open test.md in viewer > See test.md in the list Output Screenshots
Flakiness  sync.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots
Flakiness  share.spec.js • 1 flaky test

View Output Video

Test Artifacts
Open test.md in viewer > Share a file with download disabled shows an error Output Screenshots
Flakiness  api/UsersApi.spec.js • 1 flaky test

View Output Video

Test Artifacts
The user mention API > fetches users with valid session Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl juliushaertl added bug Something isn't working 4. to release and removed 3. to review labels Jun 22, 2023
@juliushaertl juliushaertl added this to the Nextcloud 28 milestone Jun 22, 2023
@susnux
Copy link
Contributor Author

susnux commented Jun 22, 2023

/compile amend

Replace invalid combinators, for reference see https://sass-lang.com/documentation/breaking-changes/bogus-combinators

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@juliushaertl juliushaertl merged commit 270b21b into main Jun 22, 2023
30 of 32 checks passed
@juliushaertl juliushaertl deleted the fix/invalid-sass branch June 22, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants