Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fade out user cursor labels after five seconds of inactivity #4336

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Fade out user cursor labels after five seconds of inactivity #4336

merged 3 commits into from
Jul 28, 2023

Commits on Jul 28, 2023

  1. Fade out user cursor labels after inactivity 

    Implementation details:
* Add a custom CollaborationCursor Tiptap extension
* Add CSS to fade out the cursor label after some time.
* Listen for Yjs updates.
  - If it's a doc change by ourself, update the timestamp of own user in
    awareness state.
  - If it's a remote awareness update, add back the CSS class to the
    corresponding cursor.
  - Wait 50ms before showing the cursor in the DOM to account for cases
    where the cursor gets re-rendered by y-prosemirror.

Fixes: #4126

Signed-off-by: Jonas <[email protected]>
    @mejo- @max-nextcloud
    mejo- authored and max-nextcloud committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    b7baceb View commit details
    Browse the repository at this point in the history

  2. fix(sync): prevent duplicate pushes 

    Document changes trigger awareness updates.
Wait before sending them in a push request so they can be combined.

Also make use of prosemirrors transactions to detect own changes
instead of listening to yjs updates.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    928fe35 View commit details
    Browse the repository at this point in the history

  3. chore(assets): Recompile assets 

    Signed-off-by: nextcloud-command <[email protected]>
    @nextcloud-command
    nextcloud-command committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    7332d99 View commit details
    Browse the repository at this point in the history